Move default version to repo.pp#768
Closed
mikhaildudzin wants to merge 1 commit intovoxpupuli:masterfrom
Closed
Conversation
h-haaks
reviewed
Jun 10, 2025
| fail('`version` or `repo_location` is required') | ||
| $version = '5.0' | ||
| } | ||
| if $version != undef and $repo_location != undef { |
Contributor
There was a problem hiding this comment.
@mikhaildudzin please have a look at #779. I have removed this test so that $version is just ignored when $repo_location is set.
Author
There was a problem hiding this comment.
LGTM, going to close this PR
Thanks for collaboration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Default version in globals.pp doesn't allow to use repo_location and having repo_location doesn't work at all, because it fails on check, as version is always defined
if $version != undef and $repo_location != undef { fail('version' is not supported with 'repo_location') }To fix this I propose to set default version only if both $version and $repo_location are undef.
This Pull Request (PR) fixes the following issues
One can't use repo_location setting